优化查询

flow-system/flow-system-biz/src/main/java/com/flow/dao/DeptDao.java

@@ -4,6 +4,7 @@ package com.flow.dao;
 import com.flow.common.mybatis.dao.BaseDao;
 import com.flow.entity.Dept;
 import com.flow.entity.User;
+import org.apache.ibatis.annotations.Param;
 import org.apache.ibatis.annotations.Select;
 
 import java.util.List;
@@ -11,7 +12,7 @@ import java.util.List;
 public interface DeptDao extends BaseDao<Dept> {
 
     @Select("select * from sys_user where username  = (select leader from sys_dept where id =#{id})")
-    User getLeader(String id);
+    User getLeader(@Param("id") String id);
 
     @Select({
             "<script>",
@@ -21,10 +22,10 @@ public interface DeptDao extends BaseDao<Dept> {
             "</foreach>)",
             "</script>"
     })
-    List<User> getLeader(List<String> ids);
+    List<User> getLeader(@Param("ids") List<String> ids);
 
     @Select("select * from sys_user where dept_id = #{id}")
-    List<User> getUsers(String id);
+    List<User> getUsers(@Param("id") String id);
 
     @Select({
             "<script>",
@@ -34,5 +35,5 @@ public interface DeptDao extends BaseDao<Dept> {
             "</foreach>",
             "</script>"
     })
-    List<User> getUsers(List<String> ids);
+    List<User> getUsers(@Param("ids") List<String> ids);
 }

flow-system/flow-system-biz/src/main/java/com/flow/dao/RoleDao.java

@@ -15,7 +15,7 @@ import java.util.List;
 public interface RoleDao extends BaseDao<Role> {
 
     @Select("select * from sys_menu where id in (SELECT menu_id from sys_role_menu where role_id = #{roleId})")
-    List<Menu> getPermission(Long roleId);
+    List<Menu> getPermission(@Param("roleId") Long roleId);
 
     @Insert({
             "<script>",
@@ -41,14 +41,14 @@ public interface RoleDao extends BaseDao<Role> {
     @Select({
             "<script>",
             "select * from sys_user where username in (select user_id from sys_user_role where role_id in ",
-            "<foreach item='roleId' collection='roleIds' open='(' separator=',' close=')'>",
-            "#{roleId}",
+            "<foreach item='id' collection='roleIds' open='(' separator=',' close=')'>",
+            "#{id}",
             "</foreach>)",
             "</script>"
     })
-    List<User> getUsers(List<String> roleIds);
+    List<User> getUsers(@Param("roleIds") List<String> roleIds);
 
     @Select("select * from sys_user where username in (select user_id from sys_user_role where role_id = #{roleId})")
-    List<User> getUsers(String roleId);
+    List<User> getUsers(@Param("roleId") String roleId);
 
 }

flow-system/flow-system-biz/src/main/java/com/flow/dao/UserDao.java

@@ -6,6 +6,7 @@ import com.flow.entity.Role;
 import com.flow.entity.User;
 import org.apache.ibatis.annotations.Delete;
 import org.apache.ibatis.annotations.Insert;
+import org.apache.ibatis.annotations.Param;
 import org.apache.ibatis.annotations.Select;
 
 import java.util.List;
@@ -24,7 +25,7 @@ public interface UserDao extends BaseDao<User> {
                 "</foreach>",
             "</script>"
     })
-    void authRoles(String userId, Set<String> roleIds);
+    void authRoles(@Param("userId") String userId, @Param("roleIds") Set<String> roleIds);
 
     @Delete({
             "<script>",
@@ -34,11 +35,11 @@ public interface UserDao extends BaseDao<User> {
                         + "</foreach>",
             "</script>"
     })
-    void delNotExistRoles(String userId, Set<String> roleIds);
+    void delNotExistRoles(@Param("userId") String userId, @Param("roleIds") Set<String> roleIds);
 
     @Select("select * from sys_user where username = #{username}")
-    User getLeader(String username);
+    User getLeader(@Param("username") String username);
 
     @Select("select * from sys_user where username = (select leader from sys_dept where id = (select dept_id from sys_user where username = #{username}))")
-    User getOrgLeader(String username);
+    User getOrgLeader(@Param("username") String username);
 }